search

Nexmo / nexmo-laravel

Add Vonage functionality such as SMS and voice calling to your Laravel app with this Laravel Service Provider.
MIT License
317 stars 79 forks source link

Laravel 8 compatibility #47

Closed ctschetter closed 3 years ago

ctschetter commented 3 years ago

Laravel 8 requires Guzzle 7.0.1 but the nexmo-laravel package appears to require 6.5.

You CAN follow the configuration guide to install a custom HTTP provider besides Guzzle, but this package should natively support the newest version of Laravel.

dragonmantank commented 3 years ago

Hello!

This is currently on our roadmap to update. As you mention, we do technically support any PSR-18 HTTP client (either via the HTTPlug project or in cases like Guzzle 7 which are PSR-18 compatible). I'll leave this open until we get it all sorted out.

ctschetter commented 3 years ago

Thank you, and thank you for all your work on this package! Without this update, I can't seem to make this package and Laravel 8 play nice, even with a separate HTTP client (following the guide.)

Problem 1

dragonmantank commented 3 years ago

As an update, we're updating to support Guzzle 7 out-of-the-box, so this should be resolved soon.

ctschetter commented 3 years ago

@dragonmantank outstanding! Thank you!

dragonmantank commented 3 years ago

cc7d9b_aa62fff3564f4383b1077cc42079ccf2~mv2

I released nexmo/client:2.4.0 which bumps our minimum to PHP to 7.2 and uses Guzzle 7 now, so this should be compatible. At the very least it installed in my fresh install of Laravel 8.

I'll leave this issue open for a bit until I get a concrete yes or no from a real-world application, but the underlying client release should do it.

andriihorpenko commented 3 years ago

This issue may be closed now. I've successfully upgraded to Guzzle 7 and tested Nexmo on Laravel 8 — works like a charm. Thanks!