search

Nexmo / nexmo-laravel

Add Vonage functionality such as SMS and voice calling to your Laravel app with this Laravel Service Provider.
MIT License
317 stars 79 forks source link

PHP 8 Support #51

Closed driesvints closed 3 years ago

driesvints commented 3 years ago

I didn't add PHP 8 builds as it seems this one is untested on PHP 7.3 and 7.4 as well.

driesvints commented 3 years ago

We'll need this for https://github.com/laravel/nexmo-notification-channel/pull/39

driesvints commented 3 years ago

@dragonmantank any chance we can merge and get this on tagged soon? Since PHP 8 GA is approaching rapidly atm. Thanks! :)

dragonmantank commented 3 years ago

Yup, I will get this handled by later today!

dragonmantank commented 3 years ago

Dealing with internet issues and cleaning up some stuff from our rebrand still. Should have this good to go this weekend if I still don't get it completed tonight.

driesvints commented 3 years ago

No worries at all! We still have some time for PHP 8 GA 👍

driesvints commented 3 years ago

Thanks @dragonmantank! Any idea when a new release will be tagged?

dragonmantank commented 3 years ago

As soon as some underlying dependencies get PHP 8 support. Right now the package cannot be installed due to some upstream packages (specifically laminas/laminas-diactoros - https://github.com/laminas/laminas-diactoros/pull/46)

driesvints commented 3 years ago

Looks like that got merged and tagged! 🥳

https://github.com/laminas/laminas-diactoros/releases/tag/2.5.0