search

Nexmo / nexmo-laravel

Add Vonage functionality such as SMS and voice calling to your Laravel app with this Laravel Service Provider.
MIT License
318 stars 79 forks source link

Refacto and enhancement #9

Closed percymamedy closed 6 years ago

percymamedy commented 7 years ago

Added .gitignore and .gitattributes files.

Also made some code changes to the Service provider to reflect the coding style of Laravel.

percymamedy commented 6 years ago

Seems this PR will not get reviewed and even didn't deserve a response. Closing for now.

leggetter commented 6 years ago

@percymamedy sorry this appears to have been missed. @mheap just recently joined us and I'm sure would be willing to provide some feedback.

mheap commented 6 years ago

Morning @percymamedy,

So sorry that I didn't spot this earlier. As Phil mentioned I recently joined the team and somehow missed this PR.

I've had a look through and it looks great to me! I'd like to test the PR on my local machine this afternoon but assuming everything works as expected I'll release a new version this evening

percymamedy commented 6 years ago

Thank you for reviewing my PR.. Keep me posted if any updates need be.. I can write some unit tests as well if necessary..

mheap commented 6 years ago

If you could provide tests too, that would be amazing 👍

percymamedy commented 6 years ago

@mheap done with the tests and refactoring here is what I basically added: