search

Nexmo / nexmo-spring-boot-starter

Spring Boot Starter for Nexmo
MIT License
5 stars 5 forks source link

Add More Test Coverage #3

Closed cr0wst closed 5 years ago

cr0wst commented 5 years ago

Some of the bean registration methods weren't being called because the beans are loaded using @Lazy. This means that when asserting that the beans exist in the container, we aren't testing that usable beans exist.

I added a call to get the beans out of the container to make sure they are usable.

codecov-io commented 5 years ago

Codecov Report

Merging #3 into master will increase coverage by 32.35%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #3       +/-   ##
===========================================
+ Coverage     67.64%   100%   +32.35%     
- Complexity       15     25       +10     
===========================================
  Files             2      2               
  Lines            34     33        -1     
  Branches          4      4               
===========================================
+ Hits             23     33       +10     
+ Misses           11      0       -11
Impacted Files Coverage Δ Complexity Δ
...kotlin/com/nexmo/starter/NexmoAutoConfiguration.kt 100% <100%> (+40.74%) 25 <1> (+10) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66d4b61...6356d64. Read the comment docs.