Nexmo / nexmo-spring-boot-starter

Spring Boot Starter for Nexmo

MIT License

5 stars 5 forks source link

Updated readme.md with Table of content (TOC) #9

Closed ng29 closed 3 years ago

ng29 commented 3 years ago

Updated readme.md with Table of content (TOC)

Please find PR of the below issue. Issue : #7

Cheers,

codecov-io commented 3 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##              master        #9   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        25        25           
===========================================
  Files              2         2           
  Lines             33        33           
  Branches           4         4           
===========================================
  Hits              33        33

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7196fa...68af165. Read the comment docs.

lukeocodes commented 3 years ago

hey @ng29 I dont think this README requires a toc, but it's not spam. so I am closing this PR without labels :) Thank for your contribution

ng29 commented 3 years ago

hey @ng29 I dont think this README requires a toc, but it's not spam. so I am closing this PR without labels :) Thank for your contribution

@lukeocodes Just for clarification, i started working on this issue after getting confirmation from @yallen011 and you can check this out in the conversation of issue #7 and after approval i made PR for this issue.

So IMO its not spam PR and moreover I was just contributing to open source contribution in month of Hacktoberfest.

And you closed my PR without merging, quite disappointed I am :(

PLease look into it, do let me know

yallen011 commented 3 years ago

@ng29 sorry about that. I am reopening since this was pre-approved by me.

ng29 commented 3 years ago

@ng29 sorry about that. I am reopening since this was pre-approved by me.

@yallen011 Thanks alot 👍 Also kindly review it and suggest changes if required .

Cheers

ng29 commented 3 years ago

Changes requested. Click on the Refresh icon by my name under Reviewers on the top right next to the PR title to notify me that the changes have been made and are ready for review.

Hey @yallen011 all changes have been made and thanks for pointing as it adds to my knowledge bank. Good to go for review.

ng29 commented 3 years ago

Good to go. Thank you @ng29 for contributing to the Nexmo Spring Boot Starter project. Also, if you would like to contribute more to the repo, I have just added a new issue to update the spring boot version and change the project from using the nexmo server sdk dependency to using the vonage server sdk dependency if you would like to take it. It is a basic change that shouldn't take much time to complete and I left complete instructions on what to do in the issue here. Happy Hacktoberfest 👻 🎃

Sure @yallen011 do assign me and I will look into it.

yallen011 commented 3 years ago

Awesome, that's great. Sure will

ng29 commented 3 years ago

Awesome, that's great. Sure will

Yeah, just came to know about Vonage Hacktoberfest Reward Giveaway too will fill the form tomorrow, Happy Hacktoberfest👻 🎃👻 🎃

Cheers