Remove activesupport - Githubissues

Nexmo / oas_parser

An open source Open API Spec 3 Definition Parser

MIT License

51 stars 16 forks source link

Remove activesupport #29

Closed ahx closed 5 years ago

ahx commented 5 years ago

ActiveSupport is great, but maybe we can remove it without a huge impact on redability… This PR is not that important.

[x] Don't rely on core_ext/hash/blank (blank?, present?)
[ ] Don't rely on core_ext/hash/conversions (to_xml) 🤷‍♂️

ahx commented 5 years ago

Removing blank?, present? was easy, but I have no idea how to not rely on to_xml. If you thing that this it is too much hassle, let's just close this.

mheap commented 5 years ago

A smaller dependency footprint is always worth it. Looking at .to_xml usage it's only used to find any attributes in the document. We can likely recurse through the object looking for attributes without serialising to XML first