search

Nexmo / oas_parser

An open source Open API Spec 3 Definition Parser
MIT License
51 stars 16 forks source link

Parse tags on root document object #55

Closed j-a-m-l closed 3 years ago

j-a-m-l commented 3 years ago

Resolves #54.

Since, I may use this library in the future, I may add more improvements, such as a real object instead of a Hash, but until I don't need more from this (simple, but excellent) library, I would focus on my projects.

One possible improvement that could affect several parts of the library is using OpenStruct instead of Hash, so the interface is accessed always as object properties instead of hash keys. Do you have any opinion on that @mheap?

Unrelated to that, I was having an error while running the tests because the fixture file was lowercased, but the test wasn't using that convention.

fabianrbz commented 3 years ago

@j-a-m-l thanks for the PR it looks good! We are planning to refactor the library next year and use actual objects instead of hashes - among other things :) -.

j-a-m-l commented 3 years ago

Cool, thanks for your work!