search

Nexmo / stitch-android-quickstart

A repository containing everything you need when getting started with the Nexmo Stitch API and the Android SDK
MIT License
2 stars 3 forks source link

there should be "CONVERSATION-ID" instead of "CONVERSATION_ID", otherwise the conversationID will be null in ChatActivity #16

Closed sdnazarenko closed 6 years ago

sdnazarenko commented 6 years ago

https://github.com/Nexmo/stitch-android-quickstart/blob/b16a210bac8fbbe66f54478942931df3b0dafdb8/examples/2-Inviting-members/app/src/main/java/com/nexmo/simpleconversation2/LoginActivity.java#L145

private void goToConversation(final Conversation conversation) {
    Intent intent = new Intent(LoginActivity.this, ChatActivity.class);
    intent.putExtra("CONVERSATION-ID", conversation.getConversationId());
    startActivity(intent);
}
sdnazarenko commented 6 years ago

@ChrisGuzman please have a look to this

ChrisGuzman commented 6 years ago

Hello! Thanks for filing an issue. Looking at the examples, I don't see an occurrence of where CONVERSATION-ID is one activity and CONVERSATION_ID is in another activity within the same project. Though I do see that I used CONVERSATION_ID for most of the projects except the first one. I've filed PR #18 to fix that. Does that work for you?

ChrisGuzman commented 6 years ago

Merged the PR. Thanks!