search

Nexmo / stitch-android-quickstart

A repository containing everything you need when getting started with the Nexmo Stitch API and the Android SDK
MIT License
2 stars 3 forks source link

[Suggestion] Less confusing quotes in curl commands #7

Closed alexfu closed 5 years ago

alexfu commented 6 years ago

This might just be me but, the curl commands in 1-simple-conversation are slightly hard to read because of how the single quotes terminate right before an ENV variable. For example, in section 1.3:

curl -X POST https://api.nexmo.com/beta/conversations\
 -H 'Authorization: Bearer '$APP_JWT -H 'Content-Type:application/json' -d '{"name":"nexmo-chat", "display_name": "Nexmo Chat"}'

I think it would be much easier to read if it was written with only double quotes and the quotes didn't terminate before ENV variables...

curl -X POST https://api.nexmo.com/beta/conversations\
 -H "Authorization: Bearer $APP_JWT" -H "Content-Type:application/json" -d "{\"name\":\"nexmo-chat\", \"display_name\": \"Nexmo Chat\"}"

One slight disadvantage of my suggestion might be that the quotes in the body of the request will need to be escaped but I think that escaping quotes in a string is a standard that everyone understands.

ChrisGuzman commented 5 years ago

This was fixed by using CLI commands rather than cURL