search

Nexmo / stitch-js-quickstart

A repository containing everything you need when getting started with the Nexmo Stitch API and the JavaScript SDKs
5 stars 7 forks source link

Minor changes and some feedback #7

Closed ChrisGuzman closed 7 years ago

ChrisGuzman commented 7 years ago

Add missing paren

ChrisGuzman commented 7 years ago

In section 1.5 Should we store CONVERSATION_ID and USER_ID as bash variables so they can be referenced later instead of asking users to make a note of their values?

ChrisGuzman commented 7 years ago

In 2.1 Why isn't the index.html easily copy and pasteable? I had to make some changes to the code sample to get the ui to show in chrome and firefox

ChrisGuzman commented 7 years ago

2.2 Should remind you to call npm init first? I dunno if that's me making a noob node mistake

ChrisGuzman commented 7 years ago

In 2.3 Should we remind users to wrap their code in a window.onload function or make sure their <script/> tags are at the end of the file?

ChrisGuzman commented 7 years ago

I got these errors after logging in on step 2.4. Is that normal? image

ChrisGuzman commented 7 years ago

In 2.5 it could be more clear that I'm supposed to replace the block of code in the rtc.login( method

ChrisGuzman commented 7 years ago

In 2.6 It could be made more clear that }).then(function(conv) { should be added after }).then(function(conversations) { resolves

ChrisGuzman commented 7 years ago

@AlexLakatos @leggetter had a chance to review the QS Here's my feedback. Overall I really like it. I think some of the feedback may stem from my mobile first point of thinking so let me know if you think some things aren't issues

ChrisGuzman commented 7 years ago

Could we add a script that does all the set up for you for steps 1 to 1.6? It can get kinda tedious and some users might want to see what's happening but not have to go through all the steps.

leggetter commented 7 years ago

Could we add a script that does all the set up for you for steps 1 to 1.6? It can get kinda tedious and some users might want to see what's happening but not have to go through all the steps.

We could, but I'd vote against that. Part of working through 1 to 1.6 is to become acquainted with key concepts:

1.1 Nexmo Applications 1.2 JWTs for auth 1.3 Conversations 1.4 Users 1.5 Members 1.6 JWTs tied to specific users

Could we make that clearer?

AlexLakatos commented 7 years ago

In section 1.5 Should we store CONVERSATION_ID and USER_ID as bash variables so they can be referenced later instead of asking users to make a note of their values?

We still need them to make a note, CONVERSATION_ID is used inside the JS part as well. And we'll have multiple users, saving USER_ID_N to bash will get tiresome.

ChrisGuzman commented 7 years ago

@AlexLakatos I reverted the commits removing the braces