Next-Flip / Momentum-Firmware

🐬 Feature-rich, stable and customizable Flipper Firmware

https://momentum-fw.dev

GNU General Public License v3.0

4.99k stars 206 forks source link

Archive: Favorite .mag files #110

Closed zacharyweiss closed 7 months ago

zacharyweiss commented 7 months ago

What's new

Impl favoriting .mag files (for use with magspoof commit >= 3ad981c)
Adds mag_card_10px.png to archive; I_mag_card_10px to symbols

For the reviewer

[x] I've uploaded the firmware with this patch to a device and verified its functionality
[x] I've confirmed the bug to be fixed / feature to be stable

zacharyweiss commented 7 months ago

Nix this if it seems out-of-scope, I can imagine that adding each EXT fap to have favoritable files could become unwieldy to maintain; don't want to set the wrong precedent by accident.

zacharyweiss commented 7 months ago

Do I need to manually run the build with f18 targets to configure those symbols properly? Haven't made FW PRs that cause a change to the API ver before

Willy-JL commented 7 months ago

I'll get the app updates merged in and update the submodule in this Pr

Also no, we don't deal with f18 (yet) so we leave it fully untouched to avoid unnecessary merge conflicts

Willy-JL commented 7 months ago

not sure why the build is failing tho

Willy-JL commented 7 months ago

ah its because of my changes to fbt_options.py, doesnt seem to play well here for some reason, probably due to how the repo is cloned on PRs