Next-Flip / Momentum-Firmware

🐬 Feature-rich, stable and customizable Flipper Firmware
https://momentum-fw.dev
GNU General Public License v3.0
4.99k stars 206 forks source link

Flipper Crashing in BLESpam #227

Open Choder7 opened 2 months ago

Choder7 commented 2 months ago

Describe the bug.

When clicking on Model Code in Android Device Connect in the Ble Spam App, the Flipper crashes saying it ran out of Memory.

Reproduction

  1. Open Ble Spam App on your Flipper
  2. Go to 6.Android Device Connect
  3. Hold OK
  4. Go to Model Code
  5. Press OK
  6. The Flipper should Crash saying: Out of Memory

Target

No response

Logs

No response

Anything else?

Probably happens cause there are a lot of devices loaded at the same time, and there isn't enough RAM.

Possible solutions:

AztecCodes commented 2 months ago

Yes I can reproduce this bug too.

Also in BLE Spam in Vibrate 'em All:

When you try to select a Toy Mode it automatically switches to "Bruteforce".

Reproduce:

  1. Open BLE Spam Application
  2. Go to Vibrate 'em All
  3. Hold OK
  4. Go to Toy Mode
  5. Click OK
  6. Select wanted Toy Mode - Example "Classic 1"
  7. Toy Mode should turn to "Bruteforce".

This happens for every Toy Mode besides "Random".

However it works fine if you change the Toy Mode by using the arrow buttons.

srmrmax commented 2 months ago

The same problem

Sometimes it's works when I connect and disconnect the Bluetooth from options but no always

AztecCodes commented 2 months ago

@srmrmax You don't have to activate Bluetooth in the Flipper Zero Settings or in the UI of Momentum to make BLE Spam work. It also works if you have Bluetooth deactivated.

Willy-JL commented 2 months ago

This is a ram problem. Not enough ram to keep the huge list of 1000+ model codes in ram. Due to how submenu widgets work, I currently don't see any viable way to mitigate this.

AztecCodes commented 2 months ago

What about the bug in Vibrate 'em All I described? You can open the list, but when you try to select one it always switches to "Bruteforce".

Willy-JL commented 2 months ago

@AztecCodes found the issue, was so stupid lol https://github.com/Next-Flip/Momentum-Apps/commit/7219d039d94e5ed0674e948e5623bc79a20a5f62