Next-Flip / Momentum-Firmware

🐬 Feature-rich, stable and customizable Flipper Firmware

https://momentum-fw.dev

GNU General Public License v3.0

4.95k stars 203 forks source link

Sub-GHz: Fix GPS "Latitute" typo, switch to "Lat" and "Lon" in .sub files #246

Closed m7i-org closed 1 month ago

m7i-org commented 1 month ago

What's new

Fixed a typoin the SubGHz GPS coordinates for reading/writing sub files

For the reviewer

[x] I've uploaded the firmware with this patch to a device and verified its functionality
[x] I've confirmed the bug to be fixed / feature to be stable

Willy-JL commented 1 month ago

also there are others that rely on the broken spelling, since it has been there for so long. for example, hackrf portapack mayhem firmware has a wardrive map which supports flipper sub files with latitute typo. @htotoo might want to keep this in mind if we do go ahead

htotoo commented 1 month ago

Thanks for the ping, will check on it!

m7i-org commented 1 month ago

Fair point, it is indeed a breaking change.

Shall we then rather agree on keeping "Latitute","Longitude" retro-compatible for reading sub files and moving on to "Lat","Lon" for reading/writing from now on?

Then I think the switch makes more sense.

m7i-org commented 1 month ago

Switched to "Lat","Lon" and looking for the older values in case they're not found.

Added an extra check to make sure that we don't run in the null island problem when reading sub-files.

htotoo commented 1 month ago

Imho lat / lon seems a good solution also the fallback part. I'll implement it the same way in Portapack.