NextCenturyCorporation / AIDA-Interchange-Format

Java/python library and validator for the AIDA Interchange Format (AIF). Originally based on isi-vista/gaia-interchange.
MIT License
21 stars 11 forks source link

Add optional uri_ref to link_to_external_kb #281

Closed rogerbock closed 4 years ago

rogerbock commented 4 years ago

This is allows a user to avoid blank nodes, which lead to non-determinism in the output

rogerbock commented 4 years ago

My editor trimmed trailing whitespace, so if you want to see the substantive change, you should hide whitespace changes.

This change should have no effect on existing code, as the argument is optional and without it the behavior is unchanged.

eaciv commented 4 years ago

@rogerbock, Thanks for this addition and sorry for the late reply. The changes look good, but we're using master exclusively for the latest release. Can you create a pull request against the develop branch?

rogerbock commented 4 years ago

Per @ecurley-nextcentury's request, closing this in favor of a pull request against the develop branch (#283)