Closed nextcen-dgemoets closed 9 months ago
@kaitlyn-sharo There seems to be a regression with the conditionalRequired
rule set. Things like requiring a character_id
or parameters
on certain actions isn't getting flagged. Could you investigate when you have available ITM hours?
Also, ideally I'd like a rule where at least one scene (including the 0th) must have end_scene_allowed=true
. It's a nice-to-have, not a requirement, though.
@kaitlyn-sharo There seems to be a regression with the
conditionalRequired
rule set. Things like requiring acharacter_id
orparameters
on certain actions isn't getting flagged. Could you investigate when you have available ITM hours?
Apparently lists are objects in python, so my type check wasn't exactly right. Added a specific check for lists to fix it. Seems to work on my end now
Also, ideally I'd like a rule where at least one scene (including the 0th) must have
end_scene_allowed=true
. It's a nice-to-have, not a requirement, though.
Added
I went through each of the rules listed in the pr and tried to break them, all of the rules seem to be properly enforced.
[Co-authored by @kaitlyn-sharo ]
characterMatching
andunique
rule typesaid_delay
to a list and require anid
next_scene
is a valid id in the list ofscenes
Injury.source_character
, which must be a validcharacter_id
in the scene (or state)characters
required inscenes[].state
state
required inscenes[1+]
parameters.evac_id
toMOVE_TO_EVAC
action mapping