NextCenturyCorporation / itm-scenario-validator

1 stars 0 forks source link

ITM-206: Update for changes through 05-Feb #20

Closed nextcen-dgemoets closed 9 months ago

nextcen-dgemoets commented 9 months ago

[Co-authored by @kaitlyn-sharo ]

nextcen-dgemoets commented 9 months ago

@kaitlyn-sharo There seems to be a regression with the conditionalRequired rule set. Things like requiring a character_id or parameters on certain actions isn't getting flagged. Could you investigate when you have available ITM hours?

nextcen-dgemoets commented 9 months ago

Also, ideally I'd like a rule where at least one scene (including the 0th) must have end_scene_allowed=true. It's a nice-to-have, not a requirement, though.

kaitlyn-sharo commented 9 months ago

@kaitlyn-sharo There seems to be a regression with the conditionalRequired rule set. Things like requiring a character_id or parameters on certain actions isn't getting flagged. Could you investigate when you have available ITM hours?

Apparently lists are objects in python, so my type check wasn't exactly right. Added a specific check for lists to fix it. Seems to work on my end now

kaitlyn-sharo commented 9 months ago

Also, ideally I'd like a rule where at least one scene (including the 0th) must have end_scene_allowed=true. It's a nice-to-have, not a requirement, though.

Added

dereknop commented 9 months ago

I went through each of the rules listed in the pr and tried to break them, all of the rules seem to be properly enforced.