NextChapterSoftware / ec2-action-builder

This is a custom GitHub action to provision and manage self-hosted runners using AWS EC2 On-Demand and/or Spot instances.
Apache License 2.0
11 stars 7 forks source link

Instance-profile, update user data #26

Open noamgreen opened 3 months ago

noamgreen commented 3 months ago

HI , can you add support to "Instance-profile" and manual enter the user data or just give the option to not "runner_no_update"

github is auto update the runner ver at start , there is not way to add "--disableupdate" in the user data section

Thanks in advance

Noam

mahdi-torabi commented 2 months ago

Would an option to pass raw CLI args to the runner startup command via a space delimited string be okay ? e.g "--sometime value --somethingElse value2"

mahdi-torabi commented 2 months ago

I am testing this as a quick solution https://github.com/NextChapterSoftware/ec2-action-builder/pull/27

I'll look into instance-profiles and custom user data after this.

noamgreen commented 2 months ago

HI , look like this part is working i add the "github_action_runner_extra_cli_args" i can conform its working Many thanks

mahdi-torabi commented 2 months ago

I'll merge it to main and draft a release later this evening.

I'd like to keep this issue open for the Instance-profile work

noamgreen commented 2 months ago

for the instance profile i think this will help https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/ec2/command/AssociateIamInstanceProfileCommand/

the instance-profile must be created in advance and have IAM police attached if you need me to add some links about the CLI commands let me know i will help

noamgreen commented 2 months ago

@mahdi-torabi Hi, did you find a way to add instance-profile

vnetmx commented 2 months ago

@noamgreen I'm working on the InstanceProfile option as I need it for a project,

https://github.com/NextChapterSoftware/ec2-action-builder/pull/29

mahdi-torabi commented 1 month ago

Merged. I'll verify and create a release this evening. There's a couple of other changes that I'd like to get out along with this