search

NextFaze / ionic-manup

Mandatory Update for Ionic
MIT License
52 stars 27 forks source link

Internationalisation Support #12

Closed MichaelMarner closed 7 years ago

MichaelMarner commented 7 years ago

Adds support for internationalisation using the ng2-translate package.

If bootstrapped with the ng2-translate module, ManUp will use it to get strings to display in the alerts. The service provides its own set of translations so app developers can get i18n support out of the box. ManUp can also be configured to use external translations provided by the host app. This allows app developers to customise the messages displayed by ManUp depending on their requirements.

This adds the necessary framework to support #1 but does not include the language files themselves.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.05%) to 68.644% when pulling e7985fd586017d97183359fb4cbada1b09409f96 on i18n into fb16a8bf89eae33707e2a2403f3809c84aab5147 on master.

MichaelMarner commented 7 years ago

screen shot 2017-03-17 at 4 11 11 pm

zbarbuto commented 7 years ago

LGTM