search

NextFaze / ionic-manup

Mandatory Update for Ionic
MIT License
52 stars 27 forks source link

Update demo instructions in the readme #23

Closed ricsantos closed 7 years ago

ricsantos commented 7 years ago

Wanted to give the module a try, so did a clone, installed ionic, tried to run it but received this error:

$ ionic emulate ios
The emulate command has been renamed. To find out more, run:

  ionic cordova emulate --help

I believe the solution is:

ionic cordova emulate ios

That would get the project running in a simulator. Append --target="iPhone-X" for the latest and greatest.

NB: Once the app launched in the simulator, no ManUp alerts appeared. I am not sure if I got it running correctly.

ricsantos commented 7 years ago

cc @zbarbuto

ricsantos commented 7 years ago

Also, not sure what branch should be merging this pr into, no develop?

zbarbuto commented 7 years ago

This is correct - ionic changed their api a while ago to namespace cordova commands.

zbarbuto commented 7 years ago

master is fine -master is what gets published to npm

zbarbuto commented 7 years ago

Ah should have picked up as well before merging - the plugin commands are also namespaced to ionic cordova plugin <cmd> - would you mind making another PR for those as well?