NextFire / apple-music-discord-rpc

🎵 Discord Rich Presence Client for the macOS Apple Music app and iTunes
MIT License
557 stars 36 forks source link

Long time for discord to update RPC. #105

Open kadewu1 opened 4 weeks ago

kadewu1 commented 4 weeks ago

So basically discord takes a pretty long time to update (or begin showing) currently playing song. Idk if it's an issue with discord or what, but it's pretty annoying. Using latest Vencord (same thing happens on vanilla) and im on m2 mac air with Sonoma.

NextFire commented 4 weeks ago

See my (maybe related) reply here: https://github.com/NextFire/apple-music-discord-rpc/issues/93#issuecomment-2296379607

You may or not want to update the timeout here: https://github.com/NextFire/apple-music-discord-rpc/blob/609179fdf28611facceb6b58a245a9b51ef1456d/music-rpc.ts#L132

kadewu1 commented 4 weeks ago

See my (maybe related) reply here: #93 (comment)

You may or not want to update the timeout here:

https://github.com/NextFire/apple-music-discord-rpc/blob/609179fdf28611facceb6b58a245a9b51ef1456d/music-rpc.ts#L132

oh, so if that's how it works then i guess there's some reasoning behind that. would there be any noticeable impact if said value would be changed? would discord even register it? as its supposedly rate limited to 15s anyways

NextFire commented 4 weeks ago

Well it would surely introduce some additional system load (so ultimately battery issue), and quite unnecessarily indeed if the Discord client is still rate limiting to 1 per 15s (I haven’t tested that).