search

NextFire / apple-music-discord-rpc

🎵 Discord Rich Presence Client for the macOS Apple Music app and iTunes
MIT License
559 stars 37 forks source link

MusicBrainz as Artwork Supplier #65

Closed sorae42 closed 1 year ago

sorae42 commented 1 year ago

MusicBrainz has a large catalog of song metadata ready to be used. Instead of uploading the cover (which is expensive), we can use MusicBrainz to supply album cover instead (only if iTunes can't find the correct cover).

However, MusicBrainz search is kinda quirky in its search, and song that does not exist on their database (mainly unreleased or WIP titles) may get the wrong album cover, or none at all. I tried to solve this problem but it's not yet perfect.

This should solve issue #50.

sorae42 commented 1 year ago

figured out how to do the checks myself now

sorae42 commented 1 year ago

should be good to go

NextFire commented 1 year ago

oh shit

NextFire commented 1 year ago

Can you repush your changes to your fork and reopen this pr? 😅