search

NextGeoss / ckanext-nextgeossharvest

Harvesters for NextGEOSS
GNU Affero General Public License v3.0
5 stars 1 forks source link

Multi polygon not saved correctly in the Database #113

Open JGulic opened 5 years ago

JGulic commented 5 years ago

CKAN Version if known (or site URL)

Please describe the expected behaviour

Opensearch should validate the multi polygons as multi polygons.

Please describe the actual behaviour

The Datahub doesn't have problems with the spatial information for multi polygons saved as polygons, but when we do an Open Search query for collections that have multi polygons we can see that they are failing the Geo Time validation.

The problem is here: https://github.com/NextGeoss/ckanext-nextgeossharvest/blob/b274e485d4cfde2a2003fa9e5c93f249e95910bd/ckanext/nextgeossharvest/lib/nextgeoss_base.py#L264

Everything is saved as Polygon.

The following collections are hitting this error: SENTINEL3_SRAL_L1_SRA SENTINEL3_SRAL_L2_LAN SENTINEL3_OLCI_L1_ERR SENTINEL3_OLCI_L2_LRR SENTINEL3_SLSTR_L1_RBT SENTINEL5P_OFFL_L2

What steps can be taken to reproduce the issue?

  1. Visit https://opensearch-ui.earthdata.nasa.gov/validations/index
  2. paste the following https://catalogue.nextgeoss.eu/opensearch/search.atom?productType=SENTINEL5P_OFFL_L2 in OpenSearch descriptor document location

Screenshot_2019-10-31 OpenSearch User Interface

joaandrade commented 5 years ago

Hi @JGulic,

I tested with other collections and it fails for all of them, e.g.: https://catalogue.nextgeoss.eu/opensearch/search.atom?productType=SENTINEL1_L1_GRD https://catalogue.nextgeoss.eu/opensearch/search.atom?productType=SENTINEL1_L1_SLC

Do you have any example of a collection compliant with this?

João

JGulic commented 5 years ago

@joaandrade you are trying to validate a search result and not a description document. This is from the NASA Opensearch validatior page:

This validation tool will take an OpenSearch Descriptor Document (OSDD) URL as input. It will then download that OSDD and validate its contents against a number of specifications, extensions, best practices and development guides. Each validation has a score between 0 (failed) and 5 (perfect score).

For the future please comment on the issues only with questions or answers regarding the issue. If you have any questions that are somehow connected to this, please open a new issue and assign it to me and Georgiana.

davidcordeiro-deimos commented 5 years ago

I was analyzing this issue and I have found an inconsistency because the validation tool will take an OpenSearch Descriptor Document (OSDD) URL as input. However, in the steps to reproduce this issue, you said to paste https://catalogue.nextgeoss.eu/opensearch/search.atom?productType=SENTINEL5P_OFFL_L2 which is not the OSDD of the collection, but the query itself.

If you paste the https://catalogue.nextgeoss.eu/opensearch/description.xml?osdd=collection, it passes all OGC OpenSearch Geo and Time Extensions validations with 100%

image

If you put a specific collection (in this file I traced the errors for Sentinel-2 L2A and SENTINEL5P OFFL L2 over this extension), and it will return different errors related with other collections such as Open Land Use. However, none of the errors mention anything related to the Polygon vs Multi-Polygon.

joaandrade commented 3 years ago

@JGulic can this issue be closed?