Avoid crashes, some refactoring by swiftlint rules.

NextLevel / NextLevelSessionExporter

🔄 Export and transcode media in Swift

http://nextlevel.engineering

MIT License

262 stars 48 forks source link

Avoid crashes, some refactoring by swiftlint rules. #15

Closed alexanderkhitev closed 5 years ago

alexanderkhitev commented 5 years ago

some refactoring

piemonte commented 5 years ago

hey @alexanderkhitev thanks for the project interest and the PR!

these changes are very good. some i'm not sure the reason for changing, so will probably cherry-pick parts. adding an error to the completion handler is also nice.

alexanderkhitev commented 5 years ago

Hi @piemonte ! Thanks! If there are any questions, please ask.

piemonte commented 5 years ago

hey @alexanderkhitev thanks for the PR. i manually pulled in a couple changes you had made and left a few others.

c5de4b1c3fd1804685cc19df15db5f4c3ed51a88 cd9c352a3ce9c82f886ce26f2cb5386220a0af50

alexanderkhitev commented 5 years ago

Hey @piemonte ! Thank you!