search

Nextbird / nextbird

“Life support” fork of Corebird, a native GTK+ Twitter client
GNU General Public License v3.0
11 stars 1 forks source link

Make Too Many Requests errors non-modal #4

Open lucaswerkmeister opened 5 years ago

lucaswerkmeister commented 5 years ago

Whenever you get an HTTP 429 Too Many Requests error from Twitter (and even with #1 fixed, this can still happen, e. g. when loading older parts of the timeline), the error message replaces the whole timeline and there’s no option to get it back (and the “retry” button will only work once Twitter lets you make requests again, of course). It would be much nicer to show the error in some other place, so you can still read whatever timeline is already loaded. Or perhaps this particular error could even be ignored completely.

These improvements were originally suggested in baedert/corebird#845.

freecicero commented 5 years ago

THANK YOU @lucaswerkmeister for setting this up! In terms of the heartbeat/refresh issue, which I really don't understand, my question is this: Since the corebird client has a "home" button at the top, can't we just use that as a "refresh" command, and set the heartbeat/autofresh to some very large number (effectively infinite) so that it doesn't refresh at all until we hit the home button, which refreshes for us.

I see that the current heartbeat does seem to act as a regular polling, so if we can avoid the "too many" error it's good to have that as an option, but in general since I frequently linger and read back on the timeline for an extended period of time, I'd like the option to turn off the refresh completely.

But again THANK YOU!!!!!!!!!

Alexmitter commented 5 years ago

At the end I guess the only good permanent fix is to change the behaviour of the error message. Maybe changing the UI error with reset of scrolling history to something pasted to stderr. Autorefresh is working fine so far, maybe deactivating autorefresh if you are not at the very top, so no danger while you are scrolling.

Edit: Yes it make sense to deactivate the updating while not scrolled to the very top. I was just scrolling down, it updated and i started from the top again : |

freecicero commented 5 years ago

Yep, that's the problem: "Edit: Yes it make sense to deactivate the updating while not scrolled to the very top. I was just scrolling down, it updated and i started from the top again : |"