[Warrior] [Mechanic] One-Handed Weapon Specialization

[SFCDaniel]

Hello^^ Tested 2/5 One-Handed Weapon Specialization from Protection Tree if the damage increases (168-225 ranged damage here) and it didn't. It showed the 4% increase but set the original damage range 168-224 as the new 104% Value und showed 161-215 as 100%. also it didnt matter if a One-Handed Weapon was equipped or a Twohander or non Weapon at all. Defensive Stance further reduced the damage.

How it should work: The actual damage should increase by the Skill dependent Percentage(2-10%) und show the unaltered original Damage when you hover over the dps entry - times the current percentage (without changing the former values). it also should remove the Bonus if no One-Handed Weapon is equipped.

Didn't Test for Melee Issues atm

[MihawkEntropius]

Defensive stance , https://tbcdb.com/?spell=71#taught-by-quest

A defensive combat stance. Decreases damage taken by 10% and damage caused by 10%. Increases threat generated.

I assume you were referring to shown stats in your character panel, I am running some tests to see actual damage, so far my testing was with Rising Tide https://tbcdb.com/?item=32236

The results are

 

 

		test 1 0%	test 2 2%	test 3 4%	test 4 6%	test 5 8%	test 6 10%
duration		1258	1199	2308	6536	1135	831
DPS		123	126.9	128.9	130.5	137.8	141.1
hit		91.2	92.30%	91.3	90.7	87.6	87.9
miss		3.4	3.70%	4.2	4.1	3.5	2.2
Dodge		5.5	4%	4.5	4.9	5.4	6.4
crit					0.4	3.5	3.5

As for 2h damage affected by 1h talent damage increase

test 1: 5/5 talents 300 seconds 177.8 dps 95.3% Hit test 2: 0/5 talent 721 seconds 167 DPS 90.9% hit

Keep in mind that there was a lot more miss in 2nd test, 4.4% hit difference makes the difference smaller.

I don't see much evidence that there's a bug.

Correct me if you think I missed something.

[SFCDaniel]

Mainly meant the Ranged Damage not onehand or twohanded damage. Ranged damage was 168-224 before the Talent and stayed at 168-224 with One-Handed Weapon Specialization(while a one handed Weapon was equipped!) Twohanded Weapon (almost same dps) showed the same dps after skilling One Handed Weapon Specialization while Onehanded Weapon damage was increased!

The Issue is that the Talent should improve PHYSICAL DAMAGE generally so also for Ranged physical damage But that is handled like the Twohanded Weapon with no increase (same coding) since the code only activates for the equipped One handed weapon directly and sets 100% damage = 110% for Ranged+Twohanded Weapons without changing their DPS

Just try to Skill the Talent and see how Ranged Damage behaves^^

[MihawkEntropius]

You can do some ranged damage dummy testing as I did above for melee damage, for ranged damage, with and without talents.

Keep in mind you will need quite a lot of ranged attacks to reduce rng.