search

Nextdoor / ndscheduler

A flexible python library for building your own cron-like system, with REST APIs and a Web UI.
BSD 2-Clause "Simplified" License
1.08k stars 202 forks source link

Addition of Amazon ECS job, copied code from luigi.contrib.ecs.py and… #13

Open rhaarm opened 7 years ago

rhaarm commented 7 years ago

… modified for ndscheduler JobBase.

rhaarm commented 7 years ago

Thanks, I'll update. I agree about the Exceptions and boto3 try/catch. Like I said before in the original comment this was copied from luigi.contrib.ecs, so there is definitely some mods that are needed.

rhaarm commented 7 years ago

Yeah I'm using PyCharm so some of that is built-in, it's length limit is set to 160 characters. It looks like there are some other issues with 2 other files that I didn't edit.

wenbinf commented 7 years ago

@rhaarm could you pull and merge from latest master? That should fix all the flake8 error & fixed unit tests for python 3.5. Then this pull request should be good to go