Stronger sql model needed

Nextdoor / ndscheduler

A flexible python library for building your own cron-like system, with REST APIs and a Web UI.

BSD 2-Clause "Simplified" License

1.08k stars 202 forks source link

Stronger sql model needed #30

Open tschm opened 6 years ago

tschm commented 6 years ago

Your schema is weak. Can you please make sure job_id is a proper foreign key and you also include a definition for the job. Next, it all falls over once a job is deleted that still has relatives in the Executions table... Btw: I would recommend to use Pony for the job

kartick commented 5 years ago

@tschm - Could you open a PR with your suggested changes, perhaps? I just hope someone would review, and merge your changes in a timely manner :)

tschm commented 5 years ago

@kartick Very sorry. I have moved production/scheduling to apache airflow. Unfortunately I have no free capacities to address the points I have mentioned.

kartick commented 5 years ago

Understandable @tschm. It is a pretty complete solution. I looked at that as well (and Luigi) and settled for NDS for our use case.