Nextdoor / ndscheduler

A flexible python library for building your own cron-like system, with REST APIs and a Web UI.
BSD 2-Clause "Simplified" License
1.08k stars 202 forks source link

Support more APScheduler job-types #59

Open fake-name opened 5 years ago

fake-name commented 5 years ago

Basically, right now, when you import ndscheduler, it installs it's own logging global handler.

If you're using ndscheduler in a context where you have existing logging infrastructure, this is extremely annoying, because it means you wind up either having to manually remove the logger after import, or you get double-logging of all log output.

Anyways, this PR just turns off the logging built-into the library. If you want logging, use logging.basicConfig() or similar.


In general, a library should never install a global logging handler on import.

fake-name commented 4 years ago

Ok, it now also adds supports for:

fake-name commented 4 years ago

Rolled up to current master.

Any chance of this getting merged?