Nexuist / CoinMarketCapAPI

JSON API for coinmarketcap.com written in node and hosted on OpenShift.
https://coinmarketcap-nexuist.rhcloud.com
54 stars 24 forks source link

Not updating #1

Closed avenir closed 10 years ago

avenir commented 10 years ago

This is exactly what I was looking for but it's not updating correctly (rates never change).

Nexuist commented 10 years ago

Hm, I'll look into it.

Nexuist commented 10 years ago

Found the error:

TypeError: Cannot call method 'toString' of undefined
    at currencyDictionary (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/update.js:47:44)
    at null.<anonymous> (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/update.js:21:22)
    at exports.each (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/node_modules/cheerio/lib/api/traversing.js:125:24)
    at Request.result [as _callback] (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/update.js:13:13)
    at Request.self.callback (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/node_modules/request/request.js:123:22)
    at Request.EventEmitter.emit (events.js:98:17)
    at Request.<anonymous> (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/node_modules/request/request.js:877:14)
    at Request.EventEmitter.emit (events.js:117:20)
    at IncomingMessage.<anonymous> (/var/lib/openshift/53379edd4382ecd63200027d/app-root/runtime/repo/node_modules/request/request.js:828:12)
    at IncomingMessage.EventEmitter.emit (events.js:117:20)

In update.js. Apparently the coinmarketcap.com HTML was changed. I'll try to get it fixed ASAP :)

avenir commented 10 years ago

Great stuff - thanks for addressing this so quickly

Nexuist commented 10 years ago

Fixed in 514f05d :)

avenir commented 10 years ago

Working perfectly again. Much appreciated!