Nexus-Mods / NexusMods.App

Home of the development of the Nexus Mods App
https://nexus-mods.github.io/NexusMods.App/
GNU General Public License v3.0
913 stars 45 forks source link

Missing Visual Feedback for Errors During Apply #1980

Open Sewer56 opened 4 weeks ago

Sewer56 commented 4 weeks ago

Bug Report

Summary

When certain kinds of errors happen during the Apply operation in the UI, visual feedback for the user is not present.

Steps to reproduce

A Simple Cross-Platform Example.

Try the following with Cyberpunk 2077:

[!NOTE]
This example is arbitrary. Just to prove a point.

Missing redMod.exe could very easily be replaced with:

  • redMod.exe failed to run (non-zero exit code)
  • protontricks failed to find WINEPREFIX for CP2077 (Linux only)

etc.

What is the expected behaviour?

The UI should inform the user that we failed to run redMod.exe as it does not exist.

Currently the UI does not however report errors of any kind, the Apply button simply disappears, and you see only the standard Play button; as if the Apply operation has completed successfully.

Other information

This first requires UI design.

CC. @captainsandypants

erri120 commented 4 weeks ago

Related, and probably required: https://github.com/Nexus-Mods/NexusMods.App/issues/1537