search

Nexus-Mods / NexusMods.App

Home of the development of the Nexus Mods App
https://nexus-mods.github.io/NexusMods.App/
GNU General Public License v3.0
1.02k stars 47 forks source link

Deactivated fake parent library item models have an empty library items list #2023

Closed LukeNexusMods closed 1 month ago

LukeNexusMods commented 1 month ago

When highlighting a large amount of mods to delete when clicking delete the modal that appears only contains the mods that are visible on the screen and not the others selected off of the screen.

This results in you having to use the delete button multiple times to remove mods that do not display.

To reproduce download a collection or have a mod list that requires you to scroll down. Highlight all. Press delete The mods that appear in the modal will be the ones that appear on the screen currently. It will not delete mods not displayed on the screen.

erri120 commented 1 month ago

Item models that get scrolled out-of-view are deactived. Deactivation will clear the list of library items, thus selected parents out-of-view will never be deleted.

LukeNexusMods commented 1 month ago

Its the same for the Install process too. Will only install items in view.

Al12rs commented 1 month ago

I'm quite sure I specifically tested this and it was working, is this a regression from other changes?

erri120 commented 1 month ago

I'm quite sure I specifically tested this and it was working, is this a regression from other changes?

It's the same issue we've had with the selected children. This issue was always there. I'll rework the code to something that should be more reliable.

LukeNexusMods commented 1 month ago

This doesnt fix it for installing the mods. Only deleting them

LukeNexusMods commented 1 month ago

Looks like its still happening to an extent:

Ive posted a video in slack: https://nexusmods.slack.com/archives/C04NE2CTMEU/p1726489801121449?thread_ts=1726489544.691279&cid=C04NE2CTMEU

Testing with this collection: https://next.nexusmods.com/cyberpunk2077/collections/iszwwe

Al12rs commented 1 month ago

This particular bug was fixed, will open separate ticket