search

Nexus-Mods / NexusMods.App

Home of the development of the Nexus Mods App
https://nexus-mods.github.io/NexusMods.App/
GNU General Public License v3.0
1.08k stars 50 forks source link

Can't view mod files for East Scarp #2194

Open Pickysaurus opened 1 month ago

Pickysaurus commented 1 month ago

Bug Report

Summary

Some mods will not allow the user to select "View Mod Files" to see which files have been installed with the app.

Steps to reproduce

  1. Install this mod
  2. Attempt to view the mod files.
  3. Note the button is disabled.

What is the expected behaviour?

Users should always be able to view the files provided by a mod.

Other information

nexusmods.app.slim.current.log nexusmods.app.main.current.log

Al12rs commented 1 week ago

The mod contents are not shown by design in this case: This mod contains multiple modules Image In the app this gets installed as a LoadoutItemGroup with multiple LoadoutItemGroup children, each containing a bunch of files.

The idea in the past was to show the child modules are child elements of the mod entry in the LoadoutView, which would allow checking the contents of each of them individually, but that was decided against at some point.

We also decided against merging the files from the different modules into a single filetree for preview in these cases. So it is correct that the preview isn't shown since this is a collection of modules, but it isn't nice for the user that doesn't know this.

We don't have a plan for what to do in these cases, whether to show the child modules in the LoadoutView, and allow previewing that, or show the module strcture in the file viewer, or something else.

Pickysaurus commented 1 week ago

The mod contents are not shown by design in this case: This mod contains multiple modules Image In the app this gets installed as a LoadoutItemGroup with multiple LoadoutItemGroup children, each containing a bunch of files.

The idea in the past was to show the child modules are child elements of the mod entry in the LoadoutView, which would allow checking the contents of each of them individually, but that was decided against at some point.

We also decided against merging the files from the different modules into a single filetree for preview in these cases. So it is correct that the preview isn't shown since this is a collection of modules, but it isn't nice for the user that doesn't know this.

We don't have a plan for what to do in these cases, whether to show the child modules in the LoadoutView, and allow previewing that, or show the module strcture in the file viewer, or something else.

This is not great though, as the mod doesn't install properly anyway, so there's no way to know files are missing. Surely using the "View Mod Files" button should show you all files in use for that mod regardless of how the data is structured under the hood? @captainsandypants?