search

Nexus-Mods / NexusMods.Paths

Custom path library used by NexusMods.App.
https://nexus-mods.github.io/NexusMods.Paths/
GNU General Public License v3.0
6 stars 0 forks source link

Fix TemporaryFileManager not deleting directories correctly #36

Closed Al12rs closed 8 months ago

Al12rs commented 8 months ago

fixes https://github.com/Nexus-Mods/NexusMods.App/issues/904

When adding the test I found that the InMemoryFS was throwing when deleting the folder recursively, so fixed that as well.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ab2d282) 87.19% compared to head (d19fd49) 86.94%.

Files Patch % Lines
...straction/InMemoryFileSystem/InMemoryFileSystem.cs 72.22% 4 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== - Coverage 87.19% 86.94% -0.25% ========================================== Files 42 42 Lines 3123 3148 +25 Branches 537 542 +5 ========================================== + Hits 2723 2737 +14 - Misses 343 347 +4 - Partials 57 64 +7 ``` | [Flag](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/36/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/36/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `?` | | | [Windows](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/36/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `86.94% <81.48%> (+0.13%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/36/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.