Nexus-Mods / NexusMods.Paths

Custom path library used by NexusMods.App.
https://nexus-mods.github.io/NexusMods.Paths/
GNU General Public License v3.0
6 stars 0 forks source link

Update `KnownExtensions` to make fields readonly #41

Closed Sewer56 closed 7 months ago

Sewer56 commented 7 months ago

Our library currently suffers from CA2211 when building locally. Presumably, at some point, our common NuGet Props were updated, and the introduction of new rules added alongside them, broke the build.

This PR simply makes the fields readonly, to avoid the issue; as the fields shouldn't be mutated in the first place (they're meant to be constants).

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.55%. Comparing base (d163fe7) to head (d1ce3e2).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ======================================= Coverage 86.55% 86.55% ======================================= Files 42 42 Lines 3176 3176 Branches 546 546 ======================================= Hits 2749 2749 Misses 368 368 Partials 59 59 ``` | [Flag](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/41/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/41/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `86.17% <100.00%> (ø)` | | | [Windows](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/41/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `86.17% <100.00%> (ø)` | | | [macOS](https://app.codecov.io/gh/Nexus-Mods/NexusMods.Paths/pull/41/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods) | `86.11% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nexus-Mods#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.