search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
863 stars 127 forks source link

No esl flagged esp appears when filtering by light for skyrimVR #12592

Open DonFlymoor opened 1 year ago

DonFlymoor commented 1 year ago

Is your feature request related to a problem? Please describe. No esl flagged esp appears when filtering by light for skyrimVR. Although skyrimVR is not affected by esl flagged plugins, I can merge all esl flagged pluggins safely.

Describe the solution you'd like esl flagged esp plugins should be show when filtering by light, and possibly light plugins should be shown as well

Additional context I would like to merge all esl flagged pluggins, but there is no easy way to determine which ones are esl flagged

TanninOne commented 1 year ago

I'm not sure why you insist on using weird terminology. "esl flagged esp" makes no real sense, esl and esp are file extensions, not flags. A file with the esl extension implicitly has the "light" and "master" flags set (two separate flags), you insisting on differentiating between "esl flagged" and "light flagged" is just infinitely confusing because from what I can tell you do not want this to be limited to only plugins that are also masters.

But I guess I understand what you're asking for now. Currently Vortex doesn't show the "light" flag on plugins even if the file has that flag set because the game wouldn't use it. So the suggestion would be to show the flag anyway and allow filtering by it even if the game doesn't support it.

@Pickysaurus What do you think of this? Assuming it makes no functional difference within Vortex. The only difference is that the flag (icon) would show up in these games and users could see and filter by it but we wouldn't allow toggling it and it wouldn't affect the load order. The risk is it might confuse users who have half-knowledge about the light flag and might suspect a bug if a plugin is flagged light but doesn't have FE as the mod index.

Pickysaurus commented 1 year ago

@Pickysaurus What do you think of this? Assuming it makes no functional difference within Vortex. The only difference is that the flag (icon) would show up in these games and users could see and filter by it but we wouldn't allow toggling it and it wouldn't affect the load order. The risk is it might confuse users who have half-knowledge about the light flag and might suspect a bug if a plugin is flagged light but doesn't have FE as the mod index.

I agree this would be confusing for the average user. However, it seems relatively harmless if the flag is only for sorting.

I've looked to see if MO2 handles this use case for comparison and it doesn't show the flag for ESLs at all and shows (incorrectly) the FE index. image

As long as the data we show is correct, I'd be happy to see this added. I believe plugins with the ESL file extension (rather than the header flag) are the ones that don't load properly at all with VR anyway.

DonFlymoor commented 1 year ago

I believe this commit https://github.com/Nexus-Mods/extension-plugin-management/commit/2c0cad0985450d5900f8e64a73836162da5fb65a Is where the light flag was disabled.

DonFlymoor commented 1 year ago

A potential future qol feature could auto merge all esl plugins into one esp.