search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
911 stars 135 forks source link

Triage [Review] - Checking for update failed #13917

Open toebeann opened 1 year ago

toebeann commented 1 year ago

Describe the bug Vortex appears to be failing to check its GitHub releases feed for updates. It appears to be expecting a JSON response but is instead finding XML and is unable to parse it.

To Reproduce Steps to reproduce the behavior:

  1. Open Vortex
  2. See error notification "Checking for update failed"
  3. Click More
  4. See error information

Expected behavior Should be able to check for updates correctly.

Screenshots image

Platform (please complete the following information):

Additional context Full error message:

Error: Cannot parse releases feed: Error: Unable to find latest version on GitHub (https://github.com/Nexus-Mods/Vortex/releases/latest), please ensure a production release exists: SyntaxError: Unexpected token '<', "

<!DOCTYPE "... is not valid JSON
    at JSON.parse (<anonymous>)
    at GitHubProvider.getLatestTagName (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:102:38)
    at GitHubProvider.getLatestVersion (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:50:23)
    at NsisUpdater.getUpdateInfoAndProvider (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:298:19)
    at NsisUpdater.doCheckForUpdates (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:312:24)
    at Object.newError (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\builder-util-runtime\out\index.js:47:19)
    at GitHubProvider.getLatestTagName (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:106:42)
    at GitHubProvider.getLatestVersion (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:50:23)
    at NsisUpdater.getUpdateInfoAndProvider (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:298:19)
    at NsisUpdater.doCheckForUpdates (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:312:24),
XML:
<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
  <id>tag:github.com,2008:https://github.com/Nexus-Mods/Vortex/releases</id>
  <link type="text/html" rel="alternate" href="https://github.com/Nexus-Mods/Vortex/releases"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/Nexus-Mods/Vortex/releases.atom"/>
  <title>Release notes from Vortex</title>
  <updated>2023-01-11T09:13:04Z</updated>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.7.4</id>
    <updated>2023-01-11T09:43:10Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.7.4"/>
    <title>1.7.4</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;(since 1.7.x) error uploading collections&lt;/li&gt;
&lt;li&gt;(since 1.7.x) unhandled error if discovery update fails&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.7.3</id>
    <updated>2023-01-04T14:43:51Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.7.3"/>
    <title>1.7.3</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;(since 1.7) symlink deployment not working&lt;/li&gt;
&lt;li&gt;exception when using &quot;Fix&quot; on warning about using xbox variant of bethesda games&lt;/li&gt;
&lt;li&gt;exception installing mod if no game active&lt;/li&gt;
&lt;li&gt;exception installing mod dependencies if source mod got removed at the wrong time&lt;/li&gt;
&lt;li&gt;(rare) exception after installing collection&lt;/li&gt;
&lt;li&gt;(rare) exception rendering conflicts if rules cache outdated&lt;/li&gt;
&lt;li&gt;couple of rare cases where network issues could crash Vortex&lt;/li&gt;
&lt;li&gt;(SDV) exception if game gets changed while purging SDV&lt;/li&gt;
&lt;li&gt;(SDV) suggesting to enable/disable dependencies when those are already were the correct state&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;better handling of certain errors caused by invalid extension&lt;/li&gt;
&lt;li&gt;(SDV) don&#39;t show recommendations from mods when installing as part of a collection&lt;/li&gt;
&lt;li&gt;(SDV) no longer create invalid dependency if mod author copy&amp;amp;pasted sample manifest&lt;/li&gt;
&lt;li&gt;(SDV) better handling of invalid manifest&lt;/li&gt;
&lt;li&gt;(BG3) compatibility with patch 9 (this was already pushed to users as an extension update)&lt;/li&gt;
&lt;li&gt;(Battletech) better handling of errors on reimporting files to mod&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;API:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;extensions can now prevent mod dependencies/recommendations from being installed&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.7.2</id>
    <updated>2022-12-14T12:18:55Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.7.2"/>
    <title>1.7.2</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;exception if staging folder got changed for inactive game&lt;/li&gt;
&lt;li&gt;exception trying to manage game if mod directory doesn&#39;t exist (only with &quot;Automatically use suggested path for staging folder&quot; enabled)&lt;/li&gt;
&lt;li&gt;exception if user switches profile during collection install and collection switch fails&lt;/li&gt;
&lt;li&gt;random exception uploading collection if binary patching enabled&lt;/li&gt;
&lt;li&gt;error logged if installing mod for inactive game&lt;/li&gt;
&lt;li&gt;user canceling fs operations would sometimes lead to error being reported&lt;/li&gt;
&lt;li&gt;(SDV) exception if profile deleted during deployment&lt;/li&gt;
&lt;li&gt;(SDV) exception installing mod if meta info lookup fails/is missing data&lt;/li&gt;
&lt;li&gt;(SDV) mod install failed completely if mod included any invalid manifest&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;updated loot to 0.18.3&lt;/li&gt;
&lt;li&gt;(Witcher 3) added support for DX12 variant introduced with latest update&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.7.1</id>
    <updated>2022-12-07T15:07:16Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.7.1"/>
    <title>1.7.1</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;exception if updating a collection and archive gets deleted before Vortex can extract it&lt;/li&gt;
&lt;li&gt;exception if game discovery in third-party extension returns invalid results&lt;/li&gt;
&lt;li&gt;exception determining game store on first run of 1.7.0 (probably after user changed state from command line)&lt;/li&gt;
&lt;li&gt;exception trying to install recommended mods (circumstances unclear)&lt;/li&gt;
&lt;li&gt;unhandled exception on SSL protocol errors&lt;/li&gt;
&lt;li&gt;(Morrowind) using wrong registry key to discover installation directory&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;updated electron to 21.3.3&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.7.0</id>
    <updated>2022-12-06T10:43:01Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.7.0"/>
    <title>1.7.0</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;exception if certain invalid urls entered into the &quot;download from url&quot; dialog&lt;/li&gt;
&lt;li&gt;exception downloading from server sending an unrecognized header format (Content-Range)&lt;/li&gt;
&lt;li&gt;exception from certain network errors being unhandled&lt;/li&gt;
&lt;li&gt;exception if upload fails before connection established&lt;/li&gt;
&lt;li&gt;crash under specfic situation if an extension throws invalid exception&lt;/li&gt;
&lt;li&gt;rare exception in &quot;External Changes&quot; dialog if files changed on disk during deployment&lt;/li&gt;
&lt;/ul&gt;
&lt;ul&gt;
&lt;li&gt;rare exception updating the dashboard layout&lt;/li&gt;
&lt;/ul&gt;
&lt;ul&gt;
&lt;li&gt;error trying to display new files/site news if image url missing&lt;/li&gt;
&lt;li&gt;would sometimes suggest en-/disabling mod dependencies that weren&#39;t actually installed&lt;/li&gt;
&lt;li&gt;&quot;Install Recommendations&quot; dialog would sometimes show up even though all were already installed&lt;/li&gt;
&lt;li&gt;multiple errors that could cause free users canceling a collection install to receive further download dialogs&lt;/li&gt;
&lt;li&gt;tools removed from dashboard still showing up in titlebar&lt;/li&gt;
&lt;li&gt;notification if mod dependencies aren&#39;t fulfilled didn&#39;t actually trigger&lt;/li&gt;
&lt;li&gt;&quot;Rename&quot; button on collections inaccessible if collection name too long&lt;/li&gt;
&lt;li&gt;tools dashlet title blurred while in &quot;customize dashboard&quot; mode&lt;/li&gt;
&lt;li&gt;user could escape &quot;staging folder invalid&quot; dialog, leaving Vortex in an invalid state&lt;/li&gt;
&lt;li&gt;a bunch of issues around mod dependency rules provided by a meta server&lt;/li&gt;
&lt;li&gt;using US date format when using localized Vortex&lt;/li&gt;
&lt;li&gt;clicking collection instructions button opened description but clicking again didn&#39;t close it&lt;/li&gt;
&lt;li&gt;canceling collection as free user would require multiple clicks&lt;/li&gt;
&lt;li&gt;hiding tool didn&#39;t stick&lt;/li&gt;
&lt;li&gt;file based load order triggered update with undefined list&lt;/li&gt;
&lt;li&gt;(various bethesda games) exception triggered by attempt to read load order while game being switched&lt;/li&gt;
&lt;li&gt;(various bethesda games) storing wrong plugin order for GOG/XBox variants of games&lt;/li&gt;
&lt;li&gt;(various bethesda games) filtering plugins by flag broken when localization active&lt;/li&gt;
&lt;li&gt;(Morrowind, Oblivion, Fallout 3, Fallout NV) support for different language versions on XBox&lt;/li&gt;
&lt;li&gt;(Skyrim SE) would run xbox installation even if a different install was being managed&lt;/li&gt;
&lt;li&gt;(Rimworld) exception installing some mods&lt;/li&gt;
&lt;li&gt;(Witcher 3) exception if deployment manifest manipulated or from older Vortex version&lt;/li&gt;
&lt;li&gt;(Daggerfall Unity) error reported if env log missing&lt;/li&gt;
&lt;li&gt;(SDV) downloading wrong version of SMAPI&lt;/li&gt;
&lt;li&gt;(Kingdom Come: Deliverance) exception if invalid load order stored&lt;/li&gt;
&lt;li&gt;(Bannerlord) extension could not be disabled&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;Updated electron to latest version&lt;/li&gt;
&lt;li&gt;added option to automatically place staging folder on same drive as game. (currently disabled by default)&lt;/li&gt;
&lt;li&gt;By default, Vortex will now be brought to foreground whenever a download is started&lt;/li&gt;
&lt;li&gt;if installing collection to different profile, offer option to immediately switch to that profile&lt;/li&gt;
&lt;li&gt;UI improvements to collection success rating widget&lt;/li&gt;
&lt;li&gt;reduced occasional delay opening collections screen&lt;/li&gt;
&lt;li&gt;more prominently pointing out our use of LOOT for load order sorting&lt;/li&gt;
&lt;li&gt;more robust detection of which game store a game was installed through if user manually selects directory&lt;/li&gt;
&lt;li&gt;fixed layout of tool buttons in the title bar&lt;/li&gt;
&lt;li&gt;&quot;remember selection&quot; option on dialogs installing dependencies&lt;/li&gt;
&lt;li&gt;less obscure display of complex mod attributes in the mod history&lt;/li&gt;
&lt;li&gt;request to allow data collection less pushy&lt;/li&gt;
&lt;li&gt;standard dialogs with a lot of checkboxes now have enable all/disable all buttons&lt;/li&gt;
&lt;li&gt;allow larger files to be attached to feedback (40MB instead of 20MB)&lt;/li&gt;
&lt;li&gt;added option to install extensions from command line&lt;/li&gt;
&lt;li&gt;allow installing mod if no game active&lt;/li&gt;
&lt;li&gt;(various bethesda games) removed the warning when the script extender is incorrectly configured, will now be fixed silently&lt;/li&gt;
&lt;li&gt;(various bethesda games) installing script extenders from Nexus Mods page, various other improvements to SE auto install&lt;/li&gt;
&lt;li&gt;(Fallout 3) discovery of epic game store variant&lt;/li&gt;
&lt;li&gt;(Skyrim SE) support for epic game store variant&lt;/li&gt;
&lt;li&gt;(BG3) better error message if mod contains unparseable meta.lsx file&lt;/li&gt;
&lt;li&gt;(SDV) Added mod table column displaying compatibility information&lt;/li&gt;
&lt;li&gt;(SDV) integrate with SMAPI dependency system to suggest dependency installs&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;API:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;Simpler API to declare how games can be discovered&lt;/li&gt;
&lt;li&gt;nexus api functions can now be accessed via context.api.ext (typings exist for these functions)&lt;/li&gt;
&lt;li&gt;dependency rules can now be flagged &quot;soft&quot; dependencies, meaning they will suggest the installation but not report as a problem if installation isn&#39;t possible&lt;/li&gt;
&lt;li&gt;nxm links for collections can now refer to revision number &quot;latest&quot;, so it always links to the current listed revision&lt;/li&gt;
&lt;li&gt;&quot;requiresLauncher&quot; function is now passed a parameter indicating which game the store was installed with (as far as Vortex can determine)&lt;/li&gt;
&lt;li&gt;added hidden setting to control auto-updating behavior so Vortex can be distributed in other ways than our own (windows-only) installer&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.6.14</id>
    <updated>2022-10-06T11:34:36Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.6.14"/>
    <title>1.6.14</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;passing along potentially problematic environment variables when starting tools&lt;/li&gt;
&lt;li&gt;when manually limiting download speed, the settings link in the download graph got overlayed in some themes&lt;/li&gt;
&lt;li&gt;(Bethesda games) rare exception if os reported plugins.txt changing while Vortex is switching to a different game&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;updated included 7zip to version 22.0.1&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.6.13</id>
    <updated>2022-09-30T08:11:39Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.6.13"/>
    <title>1.6.13</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;exception running some games bought through GOG store&lt;/li&gt;
&lt;li&gt;rare(?) crash trying to upload collection with binary patches&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.6.12</id>
    <updated>2022-09-29T14:19:38Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.6.12"/>
    <title>1.6.12</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;switching themes didn&#39;t apply without a restart of the application&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;(Skyrim SE) Support for GOG version of the game&lt;/li&gt;
&lt;li&gt;(API) better support for variants of games behaving differently depending on which store they were bought in&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.6.11</id>
    <updated>2022-09-28T09:18:21Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.6.11"/>
    <title>1.6.11</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;unhandled exception if removing collection workshop failed&lt;/li&gt;
&lt;li&gt;(rare) exception toggling option in dialog if available options change while click being processed&lt;/li&gt;
&lt;li&gt;exception adding mod to collection&lt;/li&gt;
&lt;li&gt;exception if custom meta server returns invalid data&lt;/li&gt;
&lt;li&gt;exception if mod removed while deps being installed&lt;/li&gt;
&lt;li&gt;exception if mod not found after installation&lt;/li&gt;
&lt;li&gt;exception on mods list if mod has null for fileId&lt;/li&gt;
&lt;li&gt;upon installing collection, unrelated plugins were disabled&lt;/li&gt;
&lt;li&gt;uploading collection with multiple binary patches getting stuck&lt;/li&gt;
&lt;li&gt;collection changelog dialog sometimes not getting displayed/hidden immediately&lt;/li&gt;
&lt;li&gt;some valid mod updates not getting detected&lt;/li&gt;
&lt;li&gt;(Oblivion) script extender releases with unrecognized naming scheme not being used&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Improvements:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;upgraded electron to version 19.1.0&lt;/li&gt;
&lt;li&gt;updated free-user download speed cap text&lt;/li&gt;
&lt;li&gt;handling some error messages nicer&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
  <entry>
    <id>tag:github.com,2008:Repository/67433627/v1.6.10</id>
    <updated>2022-09-15T14:45:20Z</updated>
    <link rel="alternate" type="text/html" href="https://github.com/Nexus-Mods/Vortex/releases/tag/v1.6.10"/>
    <title>1.6.10</title>
    <content type="html">&lt;p&gt;Bugfixes:&lt;/p&gt;
&lt;ul&gt;
&lt;li&gt;failed to recover after network offline at startup&lt;/li&gt;
&lt;/ul&gt;</content>
    <author>
      <name>TanninOne</name>
    </author>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/8525754?s=60&amp;v=4"/>
  </entry>
</feed>

    at Object.newError (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\builder-util-runtime\out\index.js:47:19)
    at GitHubProvider.getLatestVersion (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\providers\GitHubProvider.js:61:42)
    at NsisUpdater.getUpdateInfoAndProvider (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:298:19)
    at NsisUpdater.doCheckForUpdates (C:\Program Files\Black Tree Gaming Ltd\Vortex\resources\app.asar\node_modules\electron-updater\out\AppUpdater.js:312:24)
Alatarius commented 1 year ago

Came here to say this very thing, error log for me is identical to what's above

toebeann commented 1 year ago

The notification seems to have stopped coming up today. I'm assuming it's a temporary misconfiguration of an external API which has been resolved. Leaving the issue open though in case the report is of use to Vortex devs

TanninOne commented 1 year ago

This was caused by a hiccup on github.com. We might be able to provide a better error message if this ever happens again