search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
919 stars 135 forks source link

Daggerfall Unity mods' files do not get deployed into correct folders unless they are packaged preserving folders structure. #14319

Closed petroid closed 1 year ago

petroid commented 1 year ago

Describe the bug If mod author/packager zipped mod's files without preserving folders structure then files get deployed into Mod Folder configured in game's settings in Vortex ({DaggerfallUnity install folder}\DaggerfallUnity_Data\StreamingAssets by default) and thus do not work.

To Reproduce Steps to reproduce the behavior:

  1. Download some Daggerfall Unity mods. For instance, at the moment of writing this, this, this and this mods are affected.
  2. Install
  3. Deploy
  4. The files are deployed into {DaggerfallUnity install folder}\DaggerfallUnity_Data\StreamingAssets folder.

Expected behavior {DaggerfallUnity install folder}\DaggerfallUnity_Data\StreamingAssets\Mods is where mods' .dfmod files should go. {DaggerfallUnity install folder}\DaggerfallUnity_Data\StreamingAssets\Sound is the correct folder for mods' .ogg sound files. {DaggerfallUnity install folder}\DaggerfallUnity_Data\StreamingAssets\Docs is for correctly named mods' .txt readme files. And so on. For instance, this, this and this mods are deployed correctly.

Platform (please complete the following information):

Additional context In Vortex there is no way to manually fix misplaced mods' files and/or fix incorrectly packaged mods.

This issue should probably go to https://github.com/Nexus-Mods/vortex-games repository but it has issues disabled. Also, fixing one game does not eliminate the problem altogether.

TanninOne commented 1 year ago

That's not a bug though, this is a request to improve the heuristic of how mods should be unpacked, there is always going to be some way for a mod author to confuse the installer.

In Vortex there is no way to manually fix misplaced mods' files and/or fix incorrectly packaged mods.

You can just open the staging folder and rearrange the files in whatever file manager you like. It's true that Vortex has no UI for this but imho it's also true there is basically no way we would beat a dedicated file manager in terms of functionality.

This issue should probably go to

Technically yes, practically we prefer to have all issues in a single tracker instead of spread out over multiple repos we'd have to monitor.

petroid commented 1 year ago

You can just open the staging folder and rearrange the files in whatever file manager you like.

That is what I'm doing now. Also I have problematic mods highlighted (neat feature btw) to remind myself to check them in case of updates/reinstalls. But that's a workaround not a fix though.

improve the heuristic of how mods should be unpacked

At this point, yes. 🙂

But on a bigger scale I'd like to have a way to improve said install heuristic (or make install scripts/rules from scratch) without need of writing code in JS... I guess that's not gonna happen anytime soon 🙁