Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
891 stars 131 forks source link

Review: Lockdown Protocol #16299

Open Akkiruk opened 3 weeks ago

Akkiruk commented 3 weeks ago

Nexus Username

rboone98

Extension URL

https://www.nexusmods.com/site/mods/1010

Game URL

https://www.nexusmods.com/lockdownprotocol

Existing Extension URL

No response

New features

No response

Information

Packaging

Testing

If a task fails, contact the author to request changes before continuing.

When reviewed and passed, please complete the following tasks:

Akkiruk commented 3 weeks ago

I realized that I just had a - in between lockdown and protocol in my index.js and my info.json which was not a part of the game on the nexus mods site. With that changed it all works now and I was able to create and install this collection.

https://next.nexusmods.com/lockdownprotocol/collections/twj7eh

I uploaded the new version to the nexus mods page https://www.nexusmods.com/site/mods/1010 and that new file I uploaded there should have all the changes but if the version you are downloading is still 1.0.97 and not 2.0.0 please let me know and I will try again.

IDCs commented 3 weeks ago

Hi there @Akkiruk, first of all thank you for your contribution!

Unfortunately the gameId value you're using in the game extension is wrong. The gameId/domainId is lockdownprotocol not lockdown-protocol.

Please change it to the correct value and you should be able to test collections as well.

Akkiruk commented 3 weeks ago

Hi there @IDCs I did end up fixing that in version 2.0.0

I uploaded the new version to the nexus mods page https://www.nexusmods.com/site/mods/1010 and that new file I uploaded there should have all the changes but if the version you are downloading is still 1.0.97 and not 2.0.0 please let me know and I will try again.

That has lockdownprotocol as the gameid and not lockdown-protocol

I have been able to successfully test collections now and created this collection as my collectoin for testing.

https://next.nexusmods.com/lockdownprotocol/collections/twj7eh

Just to confirm

the old version with the "lockdown-protocol" is version 1.0.97

the version you should be testing with the fix to make the gameid "lockdownprotocol" is version 2.0.0

I uploaded that version to the nexus mods page last night and 1.0.97 should be hidden as it doesn't work properly

EnesDincel commented 2 weeks ago

Firstly, does the game still work consistently when modded and how do we mod it?

Akkiruk commented 2 weeks ago

Firstly, does the game still work consistently when modded and how do we mod it?

Game consistency will always depend on the mods themselves you have but of all the mods I have tried so far there have not been any issues and my game has never crashed.

As far as how to mod it For now we are just waiting on @IDCs to approve the extension so it can get uploaded to vortex and make mod installation easier. You can manually download and install mods right now but you will want to ask around in the lockdown protocol discord