search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
911 stars 135 forks source link

Ensure updating the NXM links will not break Vortex #16552

Open Pickysaurus opened 1 week ago

Pickysaurus commented 1 week ago

Describe the bug Currently, several NXM links use a different ID to the game domain found on the website.

Game Game ID NXM ID
Skyrim SE skyrimspecialedition SkyrimSE
Fallout NV newvegas falloutnv
TESO elderscrollsonline teso

Related: https://github.com/Nexus-Mods/Vortex/blob/cb3cc4486c5ac7cd33871970f4eb0902120dc594/src/extensions/nexus_integration/util/convertGameId.ts#L31

We want to correct these, but ensure this doesn't prevent the application from processing NXM links for these games.

To Reproduce Inspect the NXM link for any of the games mentioned above.

Expected behaviour The downloads continue to work if these IDs are changed to align with the game domain.

Pickysaurus commented 1 week ago

I've checked with @DuskDweller regarding the status of NMM if we made this change.

Well it looks like the code to handle it is already present inside NMM

https://github.com/Nexus-Mods/Nexus-Mod-Manager/blob/b44f9b2ae7da36fa60898567e91525dcc16f1fb9/NexusClient/Bootstrapper.cs#L67

IDCs commented 1 week ago

Theoretically this should already be supported as the conversion function will fallback to the game domain name.

Pickysaurus commented 1 week ago

Wryebash does not implement NXM handling so is unaffected by this change.