Review: Sifu (New Version)

ChemGuy1611 commented 1 week ago

Nexus Username

ChemBoy1

New features

This extension adds Xbox game version support, along with the standard suite of installers I've been including in all UE games (root game folder, save, config, UE4SS, Scripts, LogicMods).

I did attempt to contact Tannin42 about the existing extension but did not receive a response.

Side note: The extension linked below is not functional and was a direct copy of the existing Tannin42 Sifu extension. It should be removed. https://www.nexusmods.com/site/mods/1005

Information

[X] I confirm the above is accurate

Packaging

[X] This extension is packaged correctly

Testing

[X] This game extension has been tested
Review Tasks

If a task fails, contact the author to request changes before continuing.

[ ] Double-check for existing extension
[ ] Is the extension packaged correctly?
[ ] Does it install into Vortex?
[ ] Does it correctly discover the game?
[ ] Does it successfully install a mod?
[ ] Does it successfully install a collection?
[ ] Does the game run correctly with the mods installed?

When reviewed and passed, please complete the following tasks:

[ ] Run the GitHub Actions to add to manifest
[ ] Contact author
[ ] Ask Community to enable the Vortex button for the game
[ ] Update the #vortex-announcements channel on Discord

IDCs commented 4 days ago

Hey @ChemGuy1611, although it's great that you added your UE installers/modTypes/etc.

Looking at the mods themselves, they all appear to follow the classic ~mods pattern and am therefore ensure if those enhancements were required in the first place.

Ultimately your game extension adds discovery support for the xbox version right? The game pass version can still be managed using the current extension by manually selecting the location of the game.

I think it would be safest to just add the xbox id to the existing extension rather than change the entire codebase when such a minor change is required.

Please let me know if I'm missing something such as the old extension not working anymore etc.

ChemGuy1611 commented 4 days ago

The existing Extension does not support the Xbox version. Xbox uses different executables and executable folders. That's the main thing with this updated extension. An entirely different structure has to be used to accommodate Xbox version and other versions simultaneously. This is similar to other UE games on Xbox, like Palworld. And other extensions I've made like Manor Lords.

That's the reason why that other (flawed) "WinGDK" extension was made. Except that guy just replaced the executable name without making any other changes, breaking support for Steam/Epic versions and without automatic discovery or being able to launch the game for Xbox

Nexus-Mods / Vortex