Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
927 stars 135 forks source link

Review: Planet Coaster 2 #16698

Closed ChemGuy1611 closed 4 days ago

ChemGuy1611 commented 1 week ago

Nexus Username

ChemBoy1

Extension URL

https://www.nexusmods.com/site/mods/1103/

Game URL

https://www.nexusmods.com/planetcoaster2/mods

Existing Extension URL

NONE

New features

Automatically installs ACSE and other mods to the "ovldata" folder.

Information

Packaging

Testing

If a task fails, contact the author to request changes before continuing.

When reviewed and passed, please complete the following tasks:

IDCs commented 4 days ago

Hey @ChemGuy1611, not a big deal - but you're downloading and installing ACSE before you actually attempt to create the ovldata directory.

I'm assuming this is working fine right now given that the game itself is distributed with that directory, but I'd flip those around.

async function setup(discovery, api, gameSpec) {
  await downloadACSE(api, gameSpec);
  return fs.ensureDirWritableAsync(path.join(discovery.path, MOD_PATH));
}
IDCs commented 4 days ago

Thank you for your contribution!