search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
895 stars 131 forks source link

"category_management" throws errors when user is not logged in #24

Closed TanninOne closed 7 years ago

TanninOne commented 7 years ago

Another case of not handling errors: If the user isn't logged in, the "category_management" extension still tries to retrieve categories and then throws an error notification at the user.

Bonus bug: The error message is very oddly worded: Title: "An error occured retrieving the Game Info" Content: "error: Error: "value" required in setHeader("APIKEY", value)"

The Title is worded as if "the Game Info" was a title and the user is expected to know what that means Nowhere does it say where the error is coming from (I only found it is related to categories by searching through the code)

The Content says "error" twice and the rest of the error message is completely cryptic to a user. It should say somewhere that this is because the user isn't logged in. And ff course that shouldn't be reported as an error in the first place.

TanninOne commented 7 years ago

This is not fixed. The error message was reworded but that wasn't the primary problem this was about.