Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
906 stars 131 forks source link

Triaged [Review] Bug Report - Other: Vortex not respecting mod name in a fomod install #4420

Open VortexFeedback opened 5 years ago

VortexFeedback commented 5 years ago

Vortex Version: 0.18.1 Memory: 4.00 GB System: win32 x64 (6.1.7601) When I install a mod with both an info.xml file and a moduleconfig.xml in the food folder the result is a properly installed mod that is not named after the mod name in the info.xml but after the zipped file that the mod came in. If I remove the moduleconfig.xml file from the fomod folder and rezip then while the mod itself amy not include all files, it's name as shown by Vortex will be the correct one in the info.xml file

I have tested my fomod repacking with NMM and I can report that that programme has no problems reporting the name of the mod as being the one specified in the info.xml file. Installing this mod into SkyrimSE using Vortex shows the same problem (suggesting it isn't the Morrowind extension?), though it isn't a Skyrim mod Vortex has no way of knowing that until LOOT complains!

Pasted here are the info.xml and moduleconfig.xml,

  1. info.xml:
The Key Mod - Fomod Zobator 1.2 https://www.nexusmods.com/morrowind/mods/45489 This is a FOMOD version of Zobator's 'The Key Mod'. No other alterations to the mod have been made. This Fomod created by diziet. Items, Objects, and Clothes
  1. moduleconfig.xml:
The Key Mod - Fomod Replaces meshes for keys in the games and also gives them more useful names. Just replaces the meshes for keys in the game. These are from Daduke's original Key Replacer 1.4 mod.

I've tried to find if I'm creating incorrect info or moduleconfig xml files but I can see nothing wrong with them. indeed when I have accidentally written an incorrect file Vortex has refused to install to install, lisitng the error!

External file: tmp-4920QzRTVj7Ee9t8.7z

Reported by: dizietemblesssma

TanninOne commented 5 years ago

Vortex collects information about a mod when the installation is done, therefore that code can only access files that exist after the installation has run its course. It tries to read fomod/info.xml, but unless your fomod installer explicitly installs that, it's not available when Vortex tries to read it.

This can be fixed of course, but it would require some non-trivial changes so it has to wait until after 1.0 is out.

dizietsma commented 5 years ago

Oh my goodness! You replied way back in May and I didn't notice. I am so sorry that's quite rude of me:)

My follow up question would be, is there actually a standard place for the fomod installer to place its own two files (and folder)? This explains why mods with just a info.xml file are named properly, because now I look I see that each such mod installs a folder named 'fomod' under 'data files' and the info.xml is inside that. Of course that overwrites any previous such file put there.:) I'm assuming then that mods I download are named properly becasue Vortex is using the info provided as part of the dowload link? This also tells me that I probably haven't been missing some obvious part of making my own fomods.:)

You've added this issue as an enhancement lable so that seems a good place to leave this. thankyou for you reply, and again, I'm sorry I missed it!

TanninOne commented 5 years ago

It would have to be "fomod/info.xml", directly in the root of the mod. And it doesn't matter that mods overwrite each other on this file because we're reading it from the staging folder where all mods live alongside each other un-overwritten.

But yeah, usually Vortex should get the name for any mod from the description on the website, the only times you'd really need Vortex to fetch the name from the info.xml is a) If your mod is not on nexus mods or b) the mod name on nexus mods is not the name you want the mod to use. Which - why would you do that for the ones you create yourself? ;) If you name your mods (and files) properly on the page everyone can profit from that.