search

Nexus-Mods / Vortex

Vortex Development
GNU General Public License v3.0
900 stars 131 forks source link

Crash: Cannot read property 'id' of undefined #7513

Closed VortexFeedback closed 4 years ago

VortexFeedback commented 4 years ago

Application Crash

System
Platform win32 10.0.18362
Architecture x64
Application Version 1.3.8
Process renderer

Message

Cannot read property 'id' of undefined

Context

gamemode = Skyrim Special Edition

Stack

TypeError: Cannot read property 'id' of undefined
    at ModWatchRenderer.createModel (C:\Users\angel\AppData\Roaming\Vortex\plugins\Modwatch for Vortex-152-0-0-2-1597331096\index.js:2725:85)
    at C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3997:40
    at Array.map (<anonymous>)
    at Object.<anonymous> (C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3996:28)
    at Generator.next (<anonymous>)
    at C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3978:71
    at new Promise (<anonymous>)
    at module.exports../src/templating.ts.__awaiter (C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3974:12)
    at Object.renderShowcase (C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3992:12)
    at C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3651:26
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\angel\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3529:58)

Reported by: LunaLoba

VortexFeedback commented 4 years ago

The crash occurs when I try to create a showcase or upload to mod watch. My nexus user name is Luna Loba

agc93 commented 4 years ago

I'm going to look into this. I honestly can't work out why it's happening but I'll add some guard clauses to hopefully prevent it

VortexFeedback commented 4 years ago

Application Crash

System
Platform win32 10.0.19041
Architecture x64
Application Version 1.3.8
Process renderer

Message

Cannot read property 'id' of undefined

Context

gamemode = Skyrim Special Edition

Stack

TypeError: Cannot read property 'id' of undefined
    at ModWatchRenderer.createModel (C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Modwatch for Vortex-152-0-0-2-1597331096\index.js:2725:85)
    at C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3997:40
    at Array.map (<anonymous>)
    at Object.<anonymous> (C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3996:28)
    at Generator.next (<anonymous>)
    at C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3978:71
    at new Promise (<anonymous>)
    at module.exports../src/templating.ts.__awaiter (C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3974:12)
    at Object.renderShowcase (C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3992:12)
    at C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3651:26
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\Fritz\AppData\Roaming\Vortex\plugins\Vortex Showcase Extension-145-0-1-1-1600270177\index.js:3529:58)

Reported by: TorinCollector

agc93 commented 4 years ago

New version of Showcase that hopefully fixes this is already uploaded and updated, just waiting for staff to update extensions file (again).

IDCs commented 4 years ago

Extensions have been updated: https://github.com/Nexus-Mods/Vortex/commit/13a93945ea88b707b92754f0945853f596e6bcc0

Going to close this as the issue is tied to a 3rd party extension and not Vortex itself.

@agc93, tag me if you'd rather I keep this open for you.

agc93 commented 4 years ago

Fine to keep this closed (theoretically its been fixed), but are all extension bugs always closed? Because as an author I have no way of knowing when bugs come up in my extensions unless someone tells me.

TanninOne commented 4 years ago

@agc93 Yeah, sorry, this issue tracker is for Vortex only. It's hard enough to keep track of it as is. We usually just tell users that an error message is from an extension and ask them to contact the author. You're welcome to refer to an issue on this tracker so you have a reference for the stack trace and such but beyond that you should track bugs yourself (e.g. through the bugs tab on your mod page: https://www.nexusmods.com/site/mods/145?tab=bugs)

agc93 commented 4 years ago

@TanninOne Fair enough. Given I've never had a user-filed bug report actually come in on any of my however-many extensions (on Nexus at least, there's been a couple of GitHub issues reported) we might want to think about making that more obvious to users to ease the load here.

Likewise, I always try and set allowReport to false on any errors I catch but obviously that doesn't help with situations like this where I don't account for it.

TanninOne commented 4 years ago

@agc93 That is actually something you may want to create a feature request for. We could make it so that your extension info.json file specifies an issue tracker url and then if an exception originates from an extension Vortex keeps track of that and the Report button could then send the user to your issue tracker instead of ours.