search

NexusMutual / cover-router

Computes optimal capacity allocation per Nexus Mutual staking pool on cover purchase
MIT License
1 stars 1 forks source link

[cover-router] Update yearly cost (annual price) for product to include commission #61

Closed mixplore closed 4 months ago

mixplore commented 5 months ago

Currently on the quote endpoint, besides premium and pool allocation requests, we get the annualPrice value. This value doesn't take into consideration the cover commission (specific to each product, can be passed as query param when calling the endpoint). The annualPrice value should include the commission.

Blocking https://github.com/NexusMutual/frontend-next/issues/93

roxdanila commented 5 months ago

ideally make the parameter optional and default its value to 0, so it stays backward compatible for others using the endpoint

mixplore commented 5 months ago

Yes, we already discussed those details on the previous request for the premiums value (which is similar, adding the commission to premium), this should come as a follow-up on that change.