Change the way we batch allocations for quote calculation - Githubissues

NexusMutual / cover-router

Computes optimal capacity allocation per Nexus Mutual staking pool on cover purchase

MIT License

1 stars 1 forks source link

Change the way we batch allocations for quote calculation #74

Closed MilGard91 closed 4 months ago

MilGard91 commented 4 months ago

Context

Issue: #71

Changes proposed in this pull request

Switch from chunking the amount by a fixed amount to chunking it by capacity and it's price

Test plan

WIP

Checklist

[x] Rebased the base branch
[x] Attached corresponding Github issue
[x] Prefixed the name with the type of change (i.e. feat, chore, test)
[x] Performed a self-review of my own code
[x] Followed the style guidelines of this project
[ ] Made corresponding changes to the documentation
[x] Didn't generate new warnings
[x] Didn't generate failures on existing tests
[x] Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback