Closed MilGard91 closed 4 months ago
looks good. as discussed maybe consider adding decimal info for the asset for the 3rd party integration (oper cover, etc..)
looks good. as discussed maybe consider adding decimal info for the asset for the 3rd party integration (oper cover, etc..)
Added asset.decimal info
@MilGard91 FE guys agreed that being consistent is better. so we went with:
{
"quote": {
...
"asset": { <--- asset object containing all info
"id": "string",
"symbol": "string",
"decimals": 18
}
},
"capacities": [
{
"poolId": "string",
"capacity": [
{
...
"asset": { <--- asset object containing all info
"id": "string",
"symbol": "string",
"decimals": 18
}
}
]
}
]
}
I would also bump the deployments package, everything else LGTM
done
Context
Issue: #83
Changes proposed in this pull request
/quote
,/capacity
and/capacity/{productId}
responses/quote
/capacity/{productId}
/capacity
Test plan
Checklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: