Closed rackstar closed 1 month ago
does our UI consume this too?
does our UI consume this too?
I don't think so. I seem to remember @mixplore mentioning FE has 6 hardcoded for USDC
does our UI consume this too?
I don't think so. I seem to remember @mixplore mentioning FE has 6 hardcoded for USDC
@Gideonnn confirmed the new asset object is not consumed in the FE
Context
open-cover asked why
asset.id
was string and if we would support input of assetId as string.looking at our smart-contracts it seems we take in assetId as a number
Pool.getAsset(uint assetId)
. So maybe we should enforce that all assetId should be in number format.Although this is technically a breaking change, since open-cover is the only consumer for now and this was only released earlier today maybe we can fix it otherwise we'll be stuck with this inconsistency.
Changes proposed in this pull request
asset.id
to numberTest plan
asset.id
to be a numberChecklist
Review
When reviewing a PR, please indicate intention in comments using the following emojis: