refactor: Change no capacity return value to empty object - Githubissues

NexusMutual / cover-router

Computes optimal capacity allocation per Nexus Mutual staking pool on cover purchase

MIT License

1 stars 1 forks source link

refactor: Change no capacity return value to empty object #99

Closed rackstar closed 3 weeks ago

rackstar commented 3 weeks ago

Context

Currently when there is capacity we return the allocation object, but if there is not enough capacity we return an empty array.

The return value should be consistent, hence changing it to empty object.

Changes proposed in this pull request

change return value to empty object on not enough capacity

Test plan

fix unit tests

Checklist

[x] Rebased the base branch
[ ] Attached corresponding Github issue
[x] Prefixed the name with the type of change (i.e. feat, chore, test)
[x] Performed a self-review of my own code
[x] Followed the style guidelines of this project
[x] Made corresponding changes to the documentation
[x] Didn't generate new warnings
[x] Didn't generate failures on existing tests
[x] Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback