fix(copy-logos): destination files no longer getting deleted - Githubissues

NexusMutual / sdk

3 stars 3 forks source link

fix(copy-logos): destination files no longer getting deleted #197

Closed mixplore closed 1 month ago

mixplore commented 1 month ago

Context

Closes https://github.com/NexusMutual/frontend-react/issues/1656

Changes proposed in this pull request

update copy logos script to overwrite logos dir files instead of erasing and recreating the dir

Test plan

add a new logo file => npm run build => npm link => go to frontend-react repo => npm run link @nexusmutual/sdk => npm run postinstall => the new logo should appear in changelog, without any of the other logos removed

Checklist

[ ] Rebased the base branch
[ ] Attached corresponding Github issue
[ ] Prefixed the name with the type of change (i.e. feat, chore, test)
[ ] Performed a self-review of my own code
[ ] Followed the style guidelines of this project
[ ] Made corresponding changes to the documentation
[ ] Didn't generate new warnings
[ ] Didn't generate failures on existing tests
[ ] Added tests that prove my fix is effective or that my feature works

Review

When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying sdk with Cloudflare Pages

Latest commit:	`e02cf84`
Status:	✅ Deploy successful!
Preview URL:	https://026ceed5.sdk-9yp.pages.dev
Branch Preview URL:	https://fix-copy-logos-script.sdk-9yp.pages.dev