There are 2 informational comments that we decided not to address, these are both on temporary functions that will be deprecated shortly after executing:
Index out of bounds - adding validation here merely transforms "index out of bounds" error to a nicer message. Moreover, we would have fork tests to ensure that we pass the correct parameters so this error should not happen when we invoke it on main-net
Custom Errors - it should be inconsequential if we keep it as requires specially since it will be deprecated shortly after.
Overview
Audit Docs
Findings
Audit Findings
There are 2 informational comments that we decided not to address, these are both on temporary functions that will be deprecated shortly after executing:
Changes proposed in this pull request
Test plan
Add unit tests on all fixes